Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add email templating #4564

Merged
merged 13 commits into from
Sep 22, 2022
Merged

Add email templating #4564

merged 13 commits into from
Sep 22, 2022
+377 −29

Conversation

dragonchaser
Copy link
Contributor

@dragonchaser dragonchaser commented Sep 13, 2022 •
edited
Loading

We have added email templating to ocis. Which are send on the SpaceShared and ShareCreated event.

refs #4303
refs cs3org/reva#3252

@update-docs
Copy link

update-docs bot commented Sep 13, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@dragonchaser dragonchaser force-pushed the email-template branch 15 times, most recently from dfa6610 to 90533a8 Compare September 15, 2022 12:45
@ownclouders
Copy link
Contributor

ownclouders commented Sep 15, 2022 •
edited
Loading

💥 Acceptance test Core-API-Tests-ocis-storage-2 failed. Further test are cancelled...

@dragonchaser dragonchaser force-pushed the email-template branch 3 times, most recently from c2d5fe4 to a5c6c76 Compare September 16, 2022 07:22
@dragonchaser dragonchaser mentioned this pull request Sep 16, 2022
Closed
@dragonchaser
Copy link
Contributor Author

/cc @mmattel https://github.com/dragonchaser/ocis/blob/email-template/services/notifications/pkg/config/config.go#L29

@dragonchaser dragonchaser force-pushed the email-template branch 4 times, most recently from dbaef7f to caa474e Compare September 20, 2022 14:02
@dragonchaser dragonchaser changed the title [WIP] add email templating Add email templating Sep 20, 2022
@dragonchaser dragonchaser marked this pull request as ready for review September 20, 2022 14:06
C0rby
C0rby suggested changes Sep 21, 2022
View reviewed changes
Copy link
Contributor

@C0rby C0rby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a few small issues.

services/notifications/pkg/email/email.go Outdated Show resolved Hide resolved
services/notifications/pkg/email/email.go Outdated Show resolved Hide resolved
services/notifications/pkg/service/service.go Outdated Show resolved Hide resolved
services/notifications/pkg/service/service.go Show resolved Hide resolved
services/notifications/pkg/service/service.go Show resolved Hide resolved
services/notifications/pkg/service/service.go Show resolved Hide resolved
services/notifications/pkg/service/service.go Show resolved Hide resolved
dragonchaser and others added 12 commits September 22, 2022 09:38
@dragonchaser @butonic
add email templating
acdfbab 
Signed-off-by: Christian Richter <[email protected]>
Co-authored-by: Jörn Dreyer <[email protected]>
@dragonchaser
embedd templates
817ac00 
Signed-off-by: Christian Richter <[email protected]>
@dragonchaser
make email templates configurable
22369b3 
Signed-off-by: Christian Richter <[email protected]>
@dragonchaser
add space notification
70690a3 
Signed-off-by: Christian Richter <[email protected]>
@dragonchaser
bugfixes
daaa08a 
Signed-off-by: Christian Richter <[email protected]>
@dragonchaser
add email subject
6ea8623 
Signed-off-by: Christian Richter <[email protected]>
@dragonchaser
add share url to email text
8e0b07b 
Signed-off-by: Christian Richter <[email protected]>
@dragonchaser
fix SpacesShared
c2ef67f 
Signed-off-by: Christian Richter <[email protected]>
@dragonchaser
handle spaceshared event
0422af2 
Signed-off-by: Christian Richter <[email protected]>
@dragonchaser
enhance templating
9402412 
Signed-off-by: Christian Richter <[email protected]>
@dragonchaser
add changelog
6c66409 
Signed-off-by: Christian Richter <[email protected]>
@dragonchaser
backport url.JoinPath for go1.18
7a8e1b8 
Signed-off-by: Christian Richter <[email protected]>
C0rby
C0rby approved these changes Sep 22, 2022
View reviewed changes
Copy link
Contributor

@C0rby C0rby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small nitpick

services/notifications/pkg/service/service.go Outdated Show resolved Hide resolved
@dragonchaser
incorporate requested changes
e96ab9f 
Signed-off-by: Christian Richter <[email protected]>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 6 Code Smells

0.0% 0.0% Coverage
14.4% 14.4% Duplication

@C0rby C0rby merged commit d7b6ecf into owncloud:master Sep 22, 2022
ownclouders pushed a commit that referenced this pull request Sep 22, 2022
commit d7b6ecf
7345c9c 
Merge: 13b2b16 e96ab9f
Author: David Christofas <[email protected]>
Date:   Thu Sep 22 14:02:36 2022 +0200

    Merge pull request #4564 from dragonchaser/email-template

    Add email templating
@mmattel mmattel mentioned this pull request Sep 22, 2022
Merged
@rhafer rhafer mentioned this pull request Sep 26, 2022
Closed
@micbar micbar mentioned this pull request Nov 25, 2022
Closed
73 tasks
@dragonchaser dragonchaser deleted the email-template branch February 6, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@C0rby C0rby C0rby approved these changes

@kobergj kobergj Awaiting requested review from kobergj

@butonic butonic Awaiting requested review from butonic

@rhafer rhafer Awaiting requested review from rhafer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dragonchaser @ownclouders @C0rby